[Fleet] Add `installed_kibana_space_id` to `epm-packages` saved objects #120517

hop-dev · 2021-12-06T16:35:10Z

Summary

Part of #74353.

Add the installed_kibana_space_id to the epm-packages saved object type, and use this field when removing assets.

This enables us to better handle integrations that have been installed in different spaces, previously if we installed an integration in the default space, then uninstalled it in a different space, the assets would not be deleted.

Manual tests:

Install a package in the default space
- check that the epm-packages saved object has installed_kibana_space_id set to default
- uninstall the package from a different space
- check that all assets have been removed.
Install a package not in the default space e.g space2
- check that the epm-packages saved object has installed_kibana_space_id set to space2
- uninstall the package from a different space e,g default space
- check that all assets have been removed.

elasticmachine · 2021-12-13T17:18:51Z

Pinging @elastic/fleet (Team:Fleet)

x-pack/plugins/fleet/server/services/epm/packages/install.ts

juliaElastic · 2021-12-14T12:52:24Z

I tested with the changes locally, and seems to be working fine. I see the space mentioned in assets.

Is that expected that when I add an integration in one space, the assets are only visible in that space, and not when I switch to another space?

spalger

kbn-test changes LGTM

hop-dev · 2021-12-15T10:08:11Z

Is that expected that when I add an integration in one space, the assets are only visible in that space, and not when I switch to another space?

Yes this is expected for now, we will need some further work to display the assets in all spaces.

juliaElastic

LGTM

joshdover

This is looking great and seems to work as intended. Have a few questions before merging below.

I did retest the case I noticed was broken in #119527 (review) and it now appears to be fixed! ✅

x-pack/plugins/fleet/dev_docs/data_model.md

x-pack/plugins/fleet/server/services/epm/packages/remove.ts

x-pack/plugins/fleet/kibana.json

x-pack/plugins/fleet/server/plugin.ts

x-pack/plugins/fleet/server/services/epm/packages/install.ts

x-pack/plugins/fleet/server/services/preconfiguration.ts

kibana-ci · 2021-12-17T15:09:00Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] OSS CI Group #9 / management field formatter set and change field formatter can change format more than once

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1154	1156	+2

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`epm-packages`	19	20	+1

Unknown metric groups

API count

id	before	after	diff
`fleet`	1266	1268	+2

History

💚 Build #13336 succeeded 68abf5eb50cef160bbe01df6b71028d270c75c1d
💚 Build #13123 succeeded befbc38183de00ae4bf670a70cd56a0b3453337e
💔 Build #13106 failed 774034fcfedf1954f0d4db0976a5efe46d9bfac7
💔 Build #12932 failed e798a837cfb50e877fbb9b76e48d6370e2f96cc7
💚 Build #12787 succeeded a13412243dba32db155cfc8a82138f25e1a62b88
💛 Build #11889 was flaky 447785b5212833ffd4f40204ad1c271b136936e1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

kibanamachine · 2021-12-17T16:26:33Z

💔 Backport failed

Status	Branch	Result
❌	8.0	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 120517

…ts (elastic#120517) # Conflicts: # x-pack/plugins/fleet/server/routes/package_policy/handlers.test.ts # x-pack/plugins/fleet/server/routes/preconfiguration/index.ts

… objects (#120517) (#121553) * [Fleet] Add `installed_kibana_space_id` to `epm-packages` saved objects (#120517) # Conflicts: # x-pack/plugins/fleet/server/routes/package_policy/handlers.test.ts # x-pack/plugins/fleet/server/routes/preconfiguration/index.ts * fix handler types Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

hop-dev changed the title ~~[Fleet] Track installation space ID on epm-packages saved objects~~ [Fleet]Add installed_kibana_space_id to epm-packages saved objects Dec 6, 2021

hop-dev added auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0 v8.1.0 labels Dec 6, 2021

hop-dev force-pushed the 74353-add-space-to-package-so branch 3 times, most recently from 447785b to a134122 Compare December 13, 2021 11:42

hop-dev marked this pull request as ready for review December 13, 2021 17:18

hop-dev requested a review from a team as a code owner December 13, 2021 17:18

juliaElastic reviewed Dec 14, 2021

View reviewed changes

x-pack/plugins/fleet/server/services/epm/packages/install.ts Outdated Show resolved Hide resolved

hop-dev force-pushed the 74353-add-space-to-package-so branch from e798a83 to 774034f Compare December 14, 2021 13:09

hop-dev requested a review from a team as a code owner December 14, 2021 13:09

hop-dev force-pushed the 74353-add-space-to-package-so branch from 774034f to befbc38 Compare December 14, 2021 14:15

spalger reviewed Dec 14, 2021

View reviewed changes

spalger approved these changes Dec 14, 2021

View reviewed changes

hop-dev force-pushed the 74353-add-space-to-package-so branch from befbc38 to 68abf5e Compare December 15, 2021 10:37

hop-dev requested a review from joshdover December 15, 2021 10:41

juliaElastic approved these changes Dec 16, 2021

View reviewed changes

joshdover reviewed Dec 16, 2021

View reviewed changes

hop-dev added 6 commits December 17, 2021 10:47

add installed_kibana_space_id to epm-packages saved object

ec4bca4

update snapshot

f341abc

pass namespace to delete assets

e726335

remove assets working

340579e

add space on package policy creation

72bb7c1

resolve TODO

19c1c56

hop-dev added 8 commits December 17, 2021 10:51

fix type error

74fce1a

add integration tests

b19beed

add space to test SO client methods

6b493d1

simplify space tests to prevent flakiness

8102fad

remove unnecessary type casting

ef33dde

make spaces plugin required

ed7bc28

use lazy getter for spaceId

573cb22

make spaceId required

ac5220c

joshdover assigned hop-dev Dec 17, 2021

hop-dev force-pushed the 74353-add-space-to-package-so branch from 68abf5e to ac5220c Compare December 17, 2021 13:50

joshdover approved these changes Dec 17, 2021

View reviewed changes

joshdover changed the title ~~[Fleet]Add installed_kibana_space_id to epm-packages saved objects~~ [Fleet] Add installed_kibana_space_id to epm-packages saved objects Dec 17, 2021

joshdover merged commit a547d4a into elastic:main Dec 17, 2021

joshdover mentioned this pull request Dec 17, 2021

[8.0] [Fleet] Add installed_kibana_space_id to epm-packages saved objects (#120517) #121553

Merged

hop-dev deleted the 74353-add-space-to-package-so branch December 17, 2021 18:55

hop-dev mentioned this pull request Jan 4, 2022

[Fleet] Move to ISavedObjectsRepository for Saved Object access #121824

Closed

hop-dev mentioned this pull request Jun 15, 2022

[Fleet] Inconsistent behavior around "Assets" tab #134378

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Add `installed_kibana_space_id` to `epm-packages` saved objects #120517

[Fleet] Add `installed_kibana_space_id` to `epm-packages` saved objects #120517

hop-dev commented Dec 6, 2021 •

edited

Loading

elasticmachine commented Dec 13, 2021

juliaElastic commented Dec 14, 2021

spalger left a comment

hop-dev commented Dec 15, 2021

juliaElastic left a comment

joshdover left a comment

kibana-ci commented Dec 17, 2021

API count

kibanamachine commented Dec 17, 2021

[Fleet] Add installed_kibana_space_id to epm-packages saved objects #120517

[Fleet] Add installed_kibana_space_id to epm-packages saved objects #120517

Conversation

hop-dev commented Dec 6, 2021 • edited Loading

Summary

elasticmachine commented Dec 13, 2021

juliaElastic commented Dec 14, 2021

spalger left a comment

Choose a reason for hiding this comment

hop-dev commented Dec 15, 2021

juliaElastic left a comment

Choose a reason for hiding this comment

joshdover left a comment

Choose a reason for hiding this comment

kibana-ci commented Dec 17, 2021

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Public APIs missing comments

Saved Objects .kibana field count

API count

History

kibanamachine commented Dec 17, 2021

💔 Backport failed

[Fleet] Add `installed_kibana_space_id` to `epm-packages` saved objects #120517

[Fleet] Add `installed_kibana_space_id` to `epm-packages` saved objects #120517

hop-dev commented Dec 6, 2021 •

edited

Loading